Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for user PDB configuration so new fields can be added #7025

Closed
peterabarr opened this issue Sep 17, 2024 · 4 comments
Closed

Allow for user PDB configuration so new fields can be added #7025

peterabarr opened this issue Sep 17, 2024 · 4 comments
Labels
feature New feature or request good-first-issue Good for newcomers

Comments

@peterabarr
Copy link

Description

What problem are you trying to solve?
I would like the PDB used by the Karpenter Helm Chart to be configurable, so that new fields can be used if desired such as unhealthyPodEvictionPolicy.

How important is this feature to you?
This feature would be nice to have but it is not urgent for our workflow.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@peterabarr peterabarr added feature New feature or request needs-triage Issues that need to be triaged labels Sep 17, 2024
@njtran
Copy link
Contributor

njtran commented Sep 17, 2024

This sounds reasonable to me. Are you open to cutting a PR?

@njtran njtran added good-first-issue Good for newcomers and removed needs-triage Issues that need to be triaged labels Sep 17, 2024
@peterabarr peterabarr mentioned this issue Sep 18, 2024
Closed
3 tasks
@peterabarr
Copy link
Author

@njtran Yeah I've opened and tested #7037

@aydosman
Copy link

Any update on this MR @njtran @peterabarr

@peterabarr
Copy link
Author

@aydosman waiting for @njtran to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Added new policy to PodDisruptionBudget peterabarr/karpenter-provider-aws
3 participants
@njtran @aydosman @peterabarr