Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type names must be PascalCased. Rename "A1B" to "A1b" #4054

Open
mpicard opened this issue Apr 12, 2023 · 2 comments
Open

Type names must be PascalCased. Rename "A1B" to "A1b" #4054

mpicard opened this issue Apr 12, 2023 · 2 comments
Labels
bug This issue is a bug. p2

Comments

@mpicard
Copy link

mpicard commented Apr 12, 2023

Describe the bug

When terraform modules contain a number followed by a single letter (eg. a1b, k8s, another2e, etc) an error is throw when executing cdktf get:

Type names must be PascalCased. Rename "A1B" to "A1b"

Expected Behavior

When executing cdktf get, the toPascalCase must handle this edge case and capitalise the single letter after the number (e.g. A1B, K8S) and the command must compile the modules and exit 0.

Current Behavior

When executing cdktf get the following is thrown:

Type names must be PascalCased. Rename "A1B" to "A1b"

Reproduction Steps

  • Create a cdktf project with template Python
  • Add a terraformModule to cdktf.json with a name that ends with a number and 1 letter.
  • run cdktf get

Possible Solution

the function cokemaker.toPascalCase should capitalise that last letter in all cases

Additional Information/Context

No response

SDK version used

0.15.5

Environment details (OS name and version, etc.)

MacOS 12.6.5

@mpicard mpicard added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 12, 2023
@mpicard
Copy link
Author

mpicard commented Apr 12, 2023

@mpicard
Copy link
Author

mpicard commented Apr 12, 2023

@mrgrain mrgrain added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2
Projects
None yet
Development

No branches or pull requests

2 participants