Support trailers in chunked publisher #6264
Open
+221
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support adding the `trailer-part` of the chunked encoded format.
dagnir
added
the
changelog-not-required
joviegas
reviewed
Jul 17, 2025
| trailerData = Collections.emptyList(); | ||
| } | ||
|
|
||
| int trailerLen = trailerData.stream().mapToInt(t -> t.remaining() + 2).sum(); |
There was a problem hiding this comment.
Each trailer ends with \r\n. I'll add a comment
...are/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java
Show resolved
Hide resolved
...are/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for HTTP trailer headers in the chunked encoding publisher, following the RFC 7230 specification. The chunked encoding format now includes the trailer-part section that allows appending additional headers after the chunked data.
- Adds trailer provider functionality to append headers to the end of chunked streams
- Implements proper formatting of trailer headers with support for multiple values
- Ensures trailers are only added to the final empty chunk (chunk size 0)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ChunkedEncodedPublisher.java | Core implementation of trailer support including provider management and proper formatting |
| ChunkedEncodedPublisherTest.java | Comprehensive test coverage for trailer functionality including edge cases and validation |
...are/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java
Outdated
Show resolved
Hide resolved
...are/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisher.java
Show resolved
Hide resolved
...amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisherTest.java
Show resolved
Hide resolved
...amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedPublisherTest.java
Show resolved
Hide resolved
|
joviegas
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support adding the
trailer-partof the chunked encoded format.Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License