Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetailsDocument does not exist in DescribeEntityOutput #5049

Closed
YasuhiroTakahashi opened this issue Oct 31, 2023 · 4 comments
Closed

DetailsDocument does not exist in DescribeEntityOutput #5049

YasuhiroTakahashi opened this issue Oct 31, 2023 · 4 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue wontfix We have determined that we will not resolve the issue.

Comments

@YasuhiroTakahashi
Copy link

Describe the bug

The recently added response item "Details Document" does not exist in DescribeEntityOutput.
https://docs.aws.amazon.com/marketplace-catalog/latest/api-reference/API_DescribeEntity.html#API_DescribeEntity_ResponseSyntax

Expected Behavior

We expect DetailsDocument to be added to DescribeEntity.

Current Behavior

The following error occurred

SerializationError: failed to unmarshal response error
    status code: 502, request id: xxxxxxxxxxx

Reproduction Steps

Below are the parts where the SDK is used.

func (s service) DescribeEntityByProductCode(ctx context.Context, settings *setting.Settings) (*catalog.Entity, error) {
	client, err := s.ConnectCatalogService(ctx, settings)
	if err != nil {
		return nil, err
	}

	res, err := client.DescribeEntityWithContext(ctx, &marketplacecatalog.DescribeEntityInput{
		Catalog:  aws.String(catalogName),
		EntityId: aws.String(settings.ProductCode.String()),
	})

	if err != nil {
		return nil, errlib.Errorf(codes.Internal, "aws marketplace error: %v", err)
	}
	if res.Details == nil {
		return nil, errlib.ErrorfWithMessage(codes.Internal, "entity details is nil")
	}

	return newEntity(res.Details)
}

Possible Solution

We would like the following types to be modified.

type DescribeEntityOutput struct {

Additional Information/Context

No response

SDK version used

v1.43.29

Environment details (Version of Go (go version)? OS name and version, etc.)

go version go1.21.3 linux/amd64

@YasuhiroTakahashi YasuhiroTakahashi added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 31, 2023
@RanVaknin RanVaknin self-assigned this Nov 1, 2023
@RanVaknin
Copy link
Contributor

Hi @YasuhiroTakahashi ,

I can confirm that that field is missing. Perhaps the codegen failed because v2 has that field. We are looking into it.
Thanks,
Ran~

@RanVaknin RanVaknin added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 2, 2023
@lucix-aws lucix-aws added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Nov 3, 2023
@lucix-aws
Copy link
Contributor

It's missing in this SDK simply because the c2j version of the model does not have that field. Conversely the smithy version of the model does, therefore it's present in v2.

I haven't checked a raw response but since they indicate that both versions exist in their docs it's worth upstreaming with the service team.

@lucix-aws
Copy link
Contributor

See #5070. We have stopped supporting fields of this type in the v1 SDK due to them being broken across services. You will need to upgrade to SDK v2 to be able to read the field.

@lucix-aws lucix-aws closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
@lucix-aws lucix-aws removed investigating This issue is being investigated and/or work is in progress to resolve the issue. service-api This issue is due to a problem in a service API, not the SDK implementation. labels Dec 13, 2023
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@lucix-aws lucix-aws added the wontfix We have determined that we will not resolve the issue. label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue wontfix We have determined that we will not resolve the issue.
Projects
None yet
Development

No branches or pull requests

3 participants