Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASG Launch lifecycle - calculate node readiness based on lack of taints #1126

Open
stanislawcabalasamsung opened this issue Feb 10, 2025 · 0 comments
Labels
Type: Enhancement New feature or request

Comments

@stanislawcabalasamsung
Copy link

Describe the feature
I would like to request extending ASG launch lifecycle support with following usecase: when node is being launched, currently NTH only takes into account Node's Ready condition to determine if node is truly ready. I would like NTH to also take int oconsideration lack of some taints. Karpenter has such feature here called startupTaints.

Basically it would mean adding new config option allowing specifying list of taints that needs to be absent in order to consider node as Ready in NTH sense. Then, here, function isNodeReady needs to check also, based on said config option, if there is any taint on the node that should not be there.

Is the feature request related to a problem?
If the CNI is not being fully ready, Node might be considered by NTH as Ready despite the fact it cannot run any workloads.

Describe alternatives you've considered

Migrating to Karpneter but it is currently time consuming.

@LikithaVemulapalli LikithaVemulapalli added the Type: Enhancement New feature or request label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants