-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3: bucketKey should support SSE-S3 #30183
Labels
@aws-cdk/aws-s3
Related to Amazon S3
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Comments
pahud
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
p2
effort/medium
Medium work item – several days of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
May 13, 2024
internal tracking - V1376578494 |
1 task
mergify bot
pushed a commit
that referenced
this issue
May 16, 2024
### Issue # (if applicable) Closes #30183 ### Reason for this change ### Description of changes ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-s3
Related to Amazon S3
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Describe the bug
bucketKeyEnabled
not allowed when the encryption is SSE-S3.aws-cdk/packages/aws-cdk-lib/aws-s3/test/bucket.test.ts
Lines 577 to 587 in 65f2bd9
But there's no document about this restriction and CloudFormation and console actually allow you to specify that.
Workaround:
Expected Behavior
Allows BucketEncryption with SSE-S3.
Current Behavior
not allowed
Reproduction Steps
Possible Solution
fix the logic here
aws-cdk/packages/aws-cdk-lib/aws-s3/lib/bucket.ts
Lines 2130 to 2136 in 65f2bd9
Additional Information/Context
No response
CDK CLI Version
v2.141.0
Framework Version
No response
Node.js Version
all
OS
all
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: