feat(docdb): i/o optimized storage type #30163
Conversation
github-actions
bot
added
star-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| if ( | ||
| props.storageType === StorageType.IOPT1 | ||
| && props.engineVersion !== undefined | ||
| && Number(props.engineVersion.split('.')[0]) < MIN_ENGINE_VERSION_FOR_IO_OPTIMIZED_STORAGE |
There was a problem hiding this comment.
The I/O optimized storage type can only be specified from engine version 5.0.0 onwards.
It would have been better if engineVersion were defined as an enum, but unfortunately, it is a string type, so I am validating it in this manner.
I look forward to hearing if there are any better methods.
badmintoncryer
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
github-actions
bot
added
the
feature-request
aws-cdk-automation
added
the
pr/needs-community-review
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
badmintoncryer
force-pushed
the
storageTypeForDocDb
branch
from
5a29871
to
541c22c
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #30165.
Reason for this change
Document DB can use I/O optimized storage type but CDK cannot configure that.
Description of changes
Add
storageTypetoClusterProps.Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license