Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2: support instanceInitiatedShutdownBehavior for EC2 instance #30164

Closed
1 of 2 tasks
badmintoncryer opened this issue May 12, 2024 · 2 comments · Fixed by #30160
Closed
1 of 2 tasks

ec2: support instanceInitiatedShutdownBehavior for EC2 instance #30164

badmintoncryer opened this issue May 12, 2024 · 2 comments · Fixed by #30160
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Add instanceInitiatedShutdownBehavior prop for EC2 Instance L2 construct.

Use Case

Cloudforamtion supports to specify instanceInitiatedShutdownBehavior for EC2 instance but CDK cannot.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2-instance-instanceinitiatedshutdownbehavior

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.141.0

Environment details (OS name and version, etc.)

irrelevant

@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 12, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label May 12, 2024
@badmintoncryer badmintoncryer changed the title ec2: support instanceInitiatedShutdownBehavior ec2: support instanceInitiatedShutdownBehavior for EC2 instance May 12, 2024
@pahud
Copy link
Contributor

pahud commented May 13, 2024

@badmintoncryer We're looking forward to your PR as always. Thank you!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 13, 2024
@mergify mergify bot closed this as completed in #30160 May 27, 2024
mergify bot pushed a commit that referenced this issue May 27, 2024
…ce (#30160)

### Issue # (if applicable)

Closes #30164

### Reason for this change

Cloudformation supports to specify `instanceInitiatedShutdownBehavior` but CDK cannot.

### Description of changes

Add `instanceInitiatedShutdownBehavior` to `InstanceProps`.

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants