Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ".ico" files (image/x-icon) not supported #388

Closed
3 tasks
Vadorequest opened this issue Oct 11, 2022 · 2 comments
Closed
3 tasks

[Bug] ".ico" files (image/x-icon) not supported #388

Vadorequest opened this issue Oct 11, 2022 · 2 comments
Labels

Comments

@Vadorequest
Copy link

Describe the bug
Files with ".ico" extension aren't supported.

To Reproduce
https://cdn.the-funding-place.unly.org//generic-favicon-default8.ico

Expected behavior
All images-based files should use the default browser behavior: display on the browser.

Please complete the following information about the solution:

  • Version: 6.0.0
  • Region: eu-west-1
  • Was the solution modified from the version published on this repository? No

Screenshots
image

Additional context

{"status":400,"code":"RequestTypeError","message":"The type of request you are making could not be processed. Please ensure that your original image is of a supported file type (jpg, png, tiff, webp, svg) and that your image request is provided in the correct syntax. Refer to the documentation for additional guidance on forming image requests."}

I believe SIH should only "extend" the native browser functionalities, and as such, should behave exactly the same way as the browser does, for all kinds of files.

It is somehow related to #387, but .ico files are definitely images and should definitely be supported.

@dougtoppin
Copy link
Contributor

This is not supported by the Sharp library which is used by this solution.
This issue has been discussed by Sharp lovell/sharp#1118

@Vadorequest
Copy link
Author

Then, I suggest it gets ignored to avoid errors. See #387 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants