Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: remove axios from integration tests #2558

Closed
1 of 2 tasks
dreamorosi opened this issue May 20, 2024 · 2 comments · Fixed by #2559
Closed
1 of 2 tasks

Maintenance: remove axios from integration tests #2558

dreamorosi opened this issue May 20, 2024 · 2 comments · Fixed by #2559
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tracer This item relates to the Tracer Utility

Comments

@dreamorosi
Copy link
Contributor

Summary

Since the first versions of Tracer we have had axios as a devDependency to test that http requests are traced correctly. At the time Axios felt like a sensible choice, however the ecosystem is moving towards either the built-in fetch or other libraries primarily developed for Node.js.

We should investigate removing it and instead use the http/https modules directly in our tests.

Why is this needed?

So that we can remove a redundant developer dependency and reduce maintenance overhead.

Which area does this relate to?

Tests

Solution

Remove the library and replace the request with a custom function based on the https module directly.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added tracer This item relates to the Tracer Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels May 20, 2024
@dreamorosi dreamorosi self-assigned this May 20, 2024
This was referenced May 20, 2024
Closed
Merged
@dreamorosi dreamorosi linked a pull request May 20, 2024 that will close this issue
test(tracer): remove axios and use https directly #2559
Merged
@github-actions GitHub Actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This is now released under v2.2.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tracer This item relates to the Tracer Utility
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(tracer): remove axios and use https directly aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi