-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: remove axios
from integration tests
#2558
Comments
dreamorosi
added
tracer
This item relates to the Tracer Utility
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
confirmed
The scope is clear, ready for implementation
labels
May 20, 2024
This was referenced May 20, 2024
This issue is now closed. Please be mindful that future comments are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so. |
github-actions
bot
added
pending-release
This item has been merged and will be released soon
and removed
confirmed
The scope is clear, ready for implementation
labels
May 27, 2024
This is now released under v2.2.0 version! |
github-actions
bot
added
completed
This item is complete and has been merged/shipped
and removed
pending-release
This item has been merged and will be released soon
labels
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Since the first versions of Tracer we have had
axios
as adevDependency
to test that http requests are traced correctly. At the time Axios felt like a sensible choice, however the ecosystem is moving towards either the built-infetch
or other libraries primarily developed for Node.js.We should investigate removing it and instead use the
http
/https
modules directly in our tests.Why is this needed?
So that we can remove a redundant developer dependency and reduce maintenance overhead.
Which area does this relate to?
Tests
Solution
Remove the library and replace the request with a custom function based on the
https
module directly.Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: