Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generating tags via codegen #2368

Open
rushmash91 opened this issue Mar 3, 2025 · 0 comments
Open

Support generating tags via codegen #2368

rushmash91 opened this issue Mar 3, 2025 · 0 comments
Assignees

Comments

@rushmash91
Copy link
Member

Currently, the code generator does not support generating tags for AWS resources. Adding this functionality would greatly improve the usability of ACK controllers, as tagging is a crucial feature for many AWS services.

Proposed Solution

  1. Extend the generator.yaml configuration to include a tags section where users can specify default tags or tag policies.

  2. Modify the code generation logic to:

    • Add tag-related fields to the resource Spec structs
    • Include tag operations in the resource manager's Create, Update, and Delete methods
    • Generate appropriate CRD schema for tag fields
  3. Update the reconciliation logic to handle tag differences between the desired and actual state of resources.

Example generator.yaml Configuration

resources:
  Repository:
    fields:
      Tags:
        type: map[string]string
    operations:
      Create:
        - TagResource
      Update:
        - TagResource
        - UntagResource
      Delete:
        - UntagResource

Benefits

  • Improved resource management capabilities for ACK controllers
@rushmash91 rushmash91 self-assigned this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant