Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[route53] DelegationSet response missing in HostedZone Status #2364

Open
andrewjeffree opened this issue Feb 28, 2025 · 2 comments
Open

[route53] DelegationSet response missing in HostedZone Status #2364

andrewjeffree opened this issue Feb 28, 2025 · 2 comments

Comments

@andrewjeffree
Copy link

Describe the bug
So I've just noticed that the route53-controller doesn't appear to store the DelegationSet data when it gets a response from CreateHostedZone which means there's no way for me to get the Name Servers of the zone to use in a RecordSet resource on a different zone. I can see it's in the CreatedHostedZoneOutput struct for aws-sdk-go-v2

Steps to reproduce
Create a HostedZone resource and check the Status fields
Expected outcome
Be able to see DelegationSet data in the HostedZone status and be able to get the Name servers of the created zone from it.

Environment

  • Kubernetes version: N/A
  • Using EKS (yes/no), if so version? N/A
  • AWS service targeted (S3, RDS, etc.): R53
@andrewjeffree
Copy link
Author

So I made an attempt at adding it here but when testing locally using a Kind cluster the field never seems to be populated. If someone can point out what I'm missing that'd be great as it's not super obvious to me considering the field is in the CRD etc.

@andrewjeffree
Copy link
Author

I got it working but I'm not sure it's the correct way to do it. Will raise it as a PR against route53-controller.

ack-prow bot pushed a commit to aws-controllers-k8s/route53-controller that referenced this issue Mar 4, 2025
Issue #, if available: aws-controllers-k8s/community#2364

Description of changes:

Add the DelegationSet to the Status of HostedZone resources so the nameservers can be retrieved to then be referenced in a RecordSet for a different HostedZone.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I'm not sure if there's a more proper way to get the sdkCreate and sdkFind calls to be generated with the relevant logic without the hook but I couldn't find a way to get that to happen. As such I've gone down the hook path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant