-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controllers Interrupted During Reconcile Create Duplicate Resources #2062
Comments
A potential option:
|
Found during crashloop caused by #2063 |
@nromriell Thank you for reporting this! I completely agree with everything you said above, and I really like the idea to use tags to track resources :) - with this said we will bring this during a community meeting today and discuss next steps. |
Thanks @a-hilaly for the quick triage and getting the discussion started during the community meeting today! I've updated the title and added a note on the description that this would impact all controllers to reflect what I've found on further investigation. I'd love to see this get a resolution despite the initial cause being related to the crashloop. Let me know if you'd like me to take getting a proposal together for this |
Edited: Removed ec2 specification, Upon further investigation this would be true for all controllers
Describe the bug
During the reconcile of a VPC if the controller is interrupted before the reconcile completes, on restart the VPC is created a second time.
This is because the status on the VPC is empty and not updated to track the remote resource until after reconciliation is completed. This leads to orphaned duplicate resources
Steps to reproduce
This was found because of a panic on the controller causing a restart during the reconcile of the VPC causing the interrupt during creation
Expected outcome
VPC status is tracked as pending before final status update on crd after creation is complete. The controller would attempt to then reconcile with remote before creating a new object
Environment
EKS version: eks.15
Kubernetes Version: 1.27
Service Targeted: EC2
EC2 ACK Controller Version: 1.2.6
The text was updated successfully, but these errors were encountered: