Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support elbv2 Listener, Rules, and TargetGroup CRDs #2048

Open
alagukannan opened this issue Mar 22, 2024 · 5 comments
Open

Support elbv2 Listener, Rules, and TargetGroup CRDs #2048

alagukannan opened this issue Mar 22, 2024 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/new-resource Categorizes issue or PR as related to a new resource. service/elbv2 Indicates issues or PRs that are related to elbv2-controller.

Comments

@alagukannan
Copy link

We are able to create a NLB but there is no way for us to create/associate a listener along with target group to it. How do we do it?

apiVersion: elbv2.services.k8s.aws/v1alpha1
kind: LoadBalancer
metadata:
  name: my-nlb
spec:
  name: "my-nlb"
  type: "network"
  scheme: "internet-facing"
  subnets:
    - subnet-dsfd
    - subnet-df 
    - subnet-df
  securityGroups: 
    - sg-dfd
  tags:
    - key: "test"
      value: "test"
@a-hilaly a-hilaly transferred this issue from aws-controllers-k8s/elbv2-controller Mar 23, 2024
@a-hilaly a-hilaly added service/elbv2 Indicates issues or PRs that are related to elbv2-controller. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 23, 2024
@a-hilaly
Copy link
Member

@alagukannan We're planning on adding two new CRDs for Listeners and TargetGroups, i'm currently working on them. Stay tuned :)

@a-hilaly a-hilaly added the kind/new-resource Categorizes issue or PR as related to a new resource. label Mar 23, 2024
@a-hilaly a-hilaly changed the title How do we create a Targetgroup to associate with the create Network load balancer Add elbv2 CRDs for Listener and TargetGroup resources Mar 23, 2024
@a-hilaly
Copy link
Member

@alagukannan We just published Rule, TargetGroup, and Listener CRDs, checkout https://aws-controllers-k8s.github.io/community/reference/elbv2/v1alpha1/listener/ ~

@a-hilaly
Copy link
Member

Still wrapping my head around how "Targets" should be implemented... Maybe we could make them just a spec field within the TargetGroup CRD? Thoughts on this approach?

@a-hilaly a-hilaly changed the title Add elbv2 CRDs for Listener and TargetGroup resources Add elbv2 Listener, Rules, and TargetGroup CRDs Mar 24, 2024
@a-hilaly a-hilaly changed the title Add elbv2 Listener, Rules, and TargetGroup CRDs Support elbv2 Listener, Rules, and TargetGroup CRDs Mar 24, 2024
@a-hilaly a-hilaly self-assigned this Mar 24, 2024
@alagukannan
Copy link
Author

Yes they should be part of the spec of TargetGroup itself. Status fields should track the individual targets status and then to syncComplete once all targets are registered and healthy

@omri-shilton
Copy link

Any news regarding targets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/new-resource Categorizes issue or PR as related to a new resource. service/elbv2 Indicates issues or PRs that are related to elbv2-controller.
Projects
None yet
Development

No branches or pull requests

3 participants