Skip to content

Commit 23a7409

Browse files
committed
pr feedback
1 parent 6d6c3dd commit 23a7409

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

packages/backend-ai/src/conversation/factory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class ConversationHandlerFunctionGenerator
5555
};
5656
const logging: typeof constructProps.logging = {};
5757
if (this.props.logging?.level) {
58-
logging.level = new LogLevelConverter().toCDKApplicationLogLevel(
58+
logging.level = new LogLevelConverter().toCDKLambdaApplicationLogLevel(
5959
this.props.logging.level
6060
);
6161
}

packages/backend-function/src/logging_options_parser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const convertLoggingOptionsToCDK = (
2020
): CDKLoggingOptions => {
2121
let level: ApplicationLogLevel | undefined = undefined;
2222
if ('level' in loggingOptions) {
23-
level = new LogLevelConverter().toCDKApplicationLogLevel(
23+
level = new LogLevelConverter().toCDKLambdaApplicationLogLevel(
2424
loggingOptions.level
2525
);
2626
}

packages/platform-core/API.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export type LocalConfigurationFileName = 'usage_data_preferences.json';
136136
// @public
137137
class LogLevelConverter {
138138
// (undocumented)
139-
toCDKApplicationLogLevel: (logLevel: LogLevel | undefined) => ApplicationLogLevel | undefined;
139+
toCDKLambdaApplicationLogLevel: (logLevel: LogLevel | undefined) => ApplicationLogLevel | undefined;
140140
}
141141

142142
// @public

packages/platform-core/src/cdk/enum_converters.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,8 @@ void describe('LogLevelConverter', () => {
154154

155155
testCases.forEach((testCase, index) => {
156156
void it(`converts log retention[${index}]`, () => {
157-
const convertedValue = new LogLevelConverter().toCDKApplicationLogLevel(
158-
testCase.input
159-
);
157+
const convertedValue =
158+
new LogLevelConverter().toCDKLambdaApplicationLogLevel(testCase.input);
160159
assert.strictEqual(convertedValue, testCase.expectedOutput);
161160
});
162161
});

packages/platform-core/src/cdk/enum_converters.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ export class LogRetentionConverter {
6767
* Converts LogLevel to CDK types.
6868
*/
6969
export class LogLevelConverter {
70-
toCDKApplicationLogLevel = (logLevel: LogLevel | undefined) => {
70+
toCDKLambdaApplicationLogLevel = (
71+
logLevel: LogLevel | undefined
72+
): ApplicationLogLevel | undefined => {
7173
switch (logLevel) {
7274
case undefined: {
7375
return undefined;

0 commit comments

Comments
 (0)