Skip to content

Commit d468e22

Browse files
jvillardfacebook-github-bot
authored andcommitted
[opam] bump opam and javalib versions
Summary: Avoid sandboxing issues and mark the incompatibility with javalib 3.0. Also remove workaround for opam bug that has been fixed and that was causing portability issues on osx where `realpath` isn't always available. Reviewed By: ngorogiannis Differential Revision: D13450029 fbshipit-source-id: ea33b06d8
1 parent 77179d2 commit d468e22

File tree

3 files changed

+10
-32
lines changed

3 files changed

+10
-32
lines changed

build-infer.sh

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -132,39 +132,15 @@ install_opam_deps () {
132132
opam install --deps-only $locked infer "$INFER_ROOT"
133133
}
134134

135-
# temporary
136-
# https://github.com/ocaml/opam-repository/issues/13040
137-
warn_javalib_sandbox () {
138-
echo "*** Did opam just fail to install javalib? If so you need to disable sandboxing." >&2
139-
echo "*** Delete the following lines in $(opam var root)/config:" >&2
140-
echo >&2
141-
echo ' wrap-build-commands:' >&2
142-
echo ' ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}' >&2
143-
echo ' wrap-install-commands:' >&2
144-
echo ' ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}' >&2
145-
echo ' wrap-remove-commands:' >&2
146-
echo ' ["%{hooks}%/sandbox.sh" "remove"] {os = "linux" | os = "macos"}' >&2
147-
echo >&2
148-
echo "*** once you are done don't forget to enable sandboxing again with" >&2
149-
echo >&2
150-
echo " opam init --reinit -ni" >&2
151-
exit 1
152-
}
153-
154135
echo "initializing opam... " >&2
155136
. "$INFER_ROOT"/scripts/opam_utils.sh
156-
# workaround bug in opam regarding symlinks
157-
# https://github.com/ocaml/opam/issues/3622
158-
OPAMROOT=${OPAMROOT:-"$HOME"/.opam}
159-
OPAMROOT=$(realpath "$OPAMROOT")
160-
export OPAMROOT
161137
if [ "$USER_OPAM_SWITCH" == "no" ]; then
162138
setup_opam
163139
fi
164140
eval $(SHELL=bash opam env)
165141
echo >&2
166142
echo "installing infer dependencies; this can take up to 30 minutes... " >&2
167-
opam_retry install_opam_deps || warn_javalib_sandbox
143+
opam_retry install_opam_deps
168144

169145
if [ "$ONLY_SETUP_OPAM" == "yes" ]; then
170146
exit 0

opam

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ depends: [
3333
"ctypes" {>="0.9.2"}
3434
"dune" {build & >="1.0"}
3535
"elina" {>="1.1"}
36-
"javalib" {>="2.3.5"}
36+
"javalib" {>="2.3.5" & <"3.0"}
3737
"mtime"
3838
"ocaml" {>="4.06.0"}
3939
"ocamlfind" {build}

opam.locked

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
opam-version: "2.0"
22
name: "infer"
3-
version: "0.15.0"
3+
version: "fb"
44
synopsis: "A static analyzer for Java, C, C++, and Objective-C"
55
maintainer: "the infer team"
66
authors: "Facebook"
@@ -25,17 +25,18 @@ depends: [
2525
"atdgen" {= "2.0.0"}
2626
"atdgen-runtime" {= "2.0.0"}
2727
"base" {= "v0.11.1"}
28+
"base-bigarray" {= "base"}
2829
"base-bytes" {= "base"}
2930
"base-threads" {= "base"}
3031
"base-unix" {= "base"}
31-
"base64" {= "2.2.0"}
32+
"base64" {= "2.3.0"}
3233
"bin_prot" {= "v0.11.0"}
3334
"biniou" {= "1.2.0"}
3435
"camlidl" {= "1.05"}
3536
"camlp4" {= "4.07+1"}
3637
"camlzip" {= "1.07"}
3738
"camomile" {= "1.0.1"}
38-
"cmdliner" {= "1.0.2"}
39+
"cmdliner" {= "1.0.3"}
3940
"conf-autoconf" {= "0.1"}
4041
"conf-gmp" {= "1"}
4142
"conf-m4" {= "1"}
@@ -51,14 +52,14 @@ depends: [
5152
"cppo" {= "1.6.5"}
5253
"cppo_ocamlbuild" {= "1.6.0"}
5354
"ctypes" {= "0.14.0"}
54-
"dune" {= "1.5.1"}
55+
"dune" {= "1.6.2"}
5556
"easy-format" {= "1.3.1"}
5657
"elina" {= "1.1"}
5758
"extlib" {= "1.7.5"}
5859
"fieldslib" {= "v0.11.0"}
5960
"integers" {= "0.2.2"}
6061
"jane-street-headers" {= "v0.11.0"}
61-
"javalib" {= "2.3.5"}
62+
"javalib" {= "2.3.6"}
6263
"jbuilder" {= "transition"}
6364
"menhir" {= "20181113"}
6465
"mlgmpidl" {= "1.2.7"}
@@ -68,6 +69,7 @@ depends: [
6869
"ocaml-compiler-libs" {= "v0.11.0"}
6970
"ocaml-config" {= "1"}
7071
"ocaml-migrate-parsetree" {= "1.1.0"}
72+
"ocaml-variants" {= "4.07.1+flambda"}
7173
"ocamlbuild" {= "0.12.0"}
7274
"ocamlfind" {= "1.8.0"}
7375
"ocamlgraph" {= "1.8.8"}
@@ -105,7 +107,7 @@ depends: [
105107
"ppxlib" {= "0.3.1"}
106108
"re" {= "1.8.0"}
107109
"result" {= "1.3"}
108-
"sawja" {= "1.5.4"}
110+
"sawja" {= "1.5.5"}
109111
"seq" {= "base"}
110112
"sexplib" {= "v0.11.0"}
111113
"sexplib0" {= "v0.11.0"}

0 commit comments

Comments
 (0)