Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JsonSchema #153

Closed
Joy-less opened this issue Dec 30, 2024 · 0 comments
Closed

Improve JsonSchema #153

Joy-less opened this issue Dec 30, 2024 · 0 comments

Comments

@Joy-less
Copy link
Contributor

The JsonSchema generator introduced in #150 is really useful. However, it provides an incorrect output for pretty basic cases:

public class Dialog {
    public DialogLine[] DialogLines { get; set; } = []; // The LLM generates any object, ignoring the DialogLine schema.
}
public class DialogLine {
    public string Name { get; set; }
    public string Speech { get; set; }
}

Consider looking into https://github.com/tryAGI/CSharpToJsonSchema, which successfully converts the above to a schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant