Refactor #28
Closed
Refactor #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate logic from standalone utility scripts (check-imports, fs-utils, wasm-utils, run-wast) into a new crate. - Consolidate build, testing, and filesystem operations under . - Update tests to reflect potential API changes related to module/memory management. - Minor simplification in execution logic.
…arison - Adapt WAST test runners (`wast_tests_new.rs` and `xtask/src/wast_tests.rs`) to use `StacklessEngine`. - Introduce `compare_wasm_values` helper function in `wast_tests_new.rs` for more robust comparison of floating-point values, including NaN and tolerance checks.
…sFrame - Adjust function type retrieval and module cloning in `StacklessFrame::new`. - Correct initial `label_arity` calculation. - Refine `label_arity` restoration logic during branching. - Ensure labels are correctly truncated after branching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.