Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

类型萃取的代码添加更多的注释。这部分东西永远是 c++ 里最晦涩难懂的 #42

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

microcai
Copy link
Member

为没有可读性的代码添加注释

这也是 c++ 需要改进的地方。类型萃取不应该靠不直观的偏特化实现

include/ucoro/awaitable.hpp Outdated Show resolved Hide resolved
include/ucoro/awaitable.hpp Outdated Show resolved Hide resolved
include/ucoro/awaitable.hpp Outdated Show resolved Hide resolved
include/ucoro/awaitable.hpp Show resolved Hide resolved
@microcai microcai requested a review from Jackarain October 20, 2024 08:00
Copy link
Member Author

@microcai microcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更新了一波

@microcai microcai force-pushed the update_traits_code branch 2 times, most recently from dc0af59 to df7f5f8 Compare October 20, 2024 08:37
Copy link
Member Author

@microcai microcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这次干掉了难懂的 is_instance_of。改为 concept 实现

Copy link
Member

@Jackarain Jackarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来没有什么问题了,只需要统一风格,一致性的代码风格会让代码从整体上看起来会更赏心悦目,也会给人一种非常职业的感觉

include/ucoro/awaitable.hpp Outdated Show resolved Hide resolved
include/ucoro/awaitable.hpp Show resolved Hide resolved
tests/test3/test.cpp Outdated Show resolved Hide resolved
Copy link
Member Author

@microcai microcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修该好了

@microcai microcai merged commit 1e36f69 into master Oct 20, 2024
12 checks passed
@microcai microcai deleted the update_traits_code branch October 20, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants