Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

不需要为 qt 特意使用 Debug 版本 静态库 #34

Merged
merged 2 commits into from
Oct 17, 2024
Merged

不需要为 qt 特意使用 Debug 版本 静态库 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7173abb
不需要为 qt 特意使用 Debug 版本 静态库
microcai Oct 17, 2024
25befff
ci: also build Debug variant to reflect the qt build fix
microcai Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
# To add more build types (Release, Debug, RelWithDebInfo, etc.) customize the build_type list.
matrix:
os: [ubuntu-24.04, windows-latest]
build_type: [Release]
build_type: [Release, Debug]
c_compiler: [gcc, clang, cl]
include:
- os: windows-latest
Expand All @@ -48,6 +48,13 @@ jobs:
- uses: actions/checkout@v4
- name: Install ninja-build tool
uses: seanmiddleditch/gha-setup-ninja@v5

- name: compiler setup
if: startsWith(runner.os, 'Linux')
shell: bash
run: |
echo "CC=${{ matrix.c_compiler }}" >> $GITHUB_ENV
echo "CXX=${{ matrix.cpp_compiler }}" >> $GITHUB_ENV

- name: Install Qt
# You may pin to the exact commit or the version.
Expand Down Expand Up @@ -97,8 +104,6 @@ jobs:
# See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
run: >
cmake -B ${{ steps.strings.outputs.build-output-dir }}
-DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }}
-DCMAKE_C_COMPILER=${{ matrix.c_compiler }}
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
-S ${{ github.workspace }}
-D "BOOST_ROOT=${{ env.BOOST_ROOT }}"
Expand Down
2 changes: 1 addition & 1 deletion tests/testqt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ qt_standard_project_setup()

qt_add_executable(testqt testqt.cpp)

set_property(TARGET testqt PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
set_property(TARGET testqt PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded")
set_target_properties(testqt PROPERTIES FOLDER "ucoro_tests")
target_link_libraries(testqt PRIVATE ucoro Qt6::Core)

Expand Down