Improve message when is missing array resource for array fields

[Paul-Bob]

Context

Improve the error message when a resource cannot be found for an array field.
field :items, as: :array

Current behavior:

Enhancement:

• Detect when the error is triggered from an array field.
• Add the --array flag in the generator command.

Expected message:

... You may generate a resource for it by running 'rails generate avo:resource item --array'.

[zhephyn]

Hey @Paul-Bob .
Is there a picture you could link to showing what the improved error message looks like?
I would love to give this issue a shot.
Could we perhaps use the better errors gem for this?

[Paul-Bob]

Hi @zhephyn thanks for looking into this.

Is there a picture you could link to showing what the improved error message looks like?

I don’t have a screenshot of the improved error message for arrays yet, as it hasn’t been implemented. The only planned change is adding the --array flag to the generator command: "You may generate a resource for it by running 'rails generate avo:resource item --array'"

I would love to give this issue a shot.

That’s awesome, thank you! We appreciate your help.

Could we perhaps use the better errors gem for this?

The better_errors gem can certainly be used in the parent application, but we wouldn’t want to add it as an Avo dependency. Each project using Avo can decide independently whether to include better_errors.

[zhephyn]

Cool. I now understand what the enhancement requires me to implement.
Is there a way i can reproduce the above error(the one in the picture above) in my local avo repository?

[Paul-Bob]

Yes @zhephyn

Is there a way i can reproduce the above error(the one in the picture above) in my local avo repository?

You can trigger this error by adding field :items, as: :array to any resource's fields and then visiting that resource's show page.

[zhephyn]

You can trigger this error by adding field :items, as: :array to any resource's fields and then visiting that resource's show page.

@Paul-Bob When i do the above, for example adding this line( field :items, as: :array) to the post.rb resource file, all i get when i navigate to the show page is a flash notice shown below instead of the error above.

There's an invalid field configuration for this resource.
field :items, as: :array

I already have a possible solution in mind however i can't tell whether it's feasible or not if i can't reproduce the error

[Paul-Bob]

@zhephyn, could you share what the lib/avo/version.rb file looks like?

[zhephyn]

I'm done implementing this. Gonna refine the code and push a PR up shortly.

[Paul-Bob]

Looking good @zhephyn!

I forgot to mention in the original scope, but let's also ensure that when the error raises on an array field, the documentation links to the array resources.

https://docs.avohq.io/3.0/array-resources.html