Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maplibre support #2666

Open
sedubois opened this issue Apr 7, 2024 · 3 comments
Open

Maplibre support #2666

sedubois opened this issue Apr 7, 2024 · 3 comments
Labels
Help wanted We could use some help with this

Comments

@sedubois
Copy link
Contributor

sedubois commented Apr 7, 2024

Feature

Add Maplibre support to Avo to have out of the box map support without requiring a dependency on an external commercial service.

Current workarounds

Sign up to Mapbox (free for 50k map loads/month).

Screenshots or screen recordings

Screenshot 2024-04-07 at 13 08 23

Additional context

Maplibre "originated as an open-source fork of mapbox-gl-js, before their switch to a non-OSS license in December 2020." (ref)

Avo makes use of Mapkick to display a map; Mapkick JS supports Maplibre but Avo depends on the Ruby gem, which makes no reference to Maplibre. Because of this, a Mapbox API token is required to just test out Avo's map feature. By contrast, Maplibre does not require an API token for its demo map/style (it can also be downloaded). Avo could switch to Mapkick JS or add a direct dependency on Maplibre.

On a related note, it would be nice for the map feature to be included in the Avo demo.

@adrianthedev
Copy link
Collaborator

We'd love to support that!
We haven't received too many requests for this, so we can't prioritize it.
Would you be able to send in a contribution?

It seems to me that maybe a patch to the gem upstream is in order so it will support maplibre?

@adrianthedev
Copy link
Collaborator

@gabrielgiroe1 can you please add the map view and other map-related things (from the dummy City resource) to the demo?

@gabrielgiroe1
Copy link
Collaborator

@gabrielgiroe1 can you please add the map view and other map-related things (from the dummy City resource) to the demo?

Yes, sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted We could use some help with this
Projects
Status: No status
Development

No branches or pull requests

3 participants