Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for Code Refactoring and Enhancement in Anime Tracker python project #3080

Open
Nancy248 opened this issue Nov 21, 2023 · 2 comments
Assignees
Labels
assigned Issues which are assigned to someone enhancement New feature or request good first issue Good for newcomers

Comments

@Nancy248
Copy link

I have reviewed the current implementation of the code in the repository, specifically in the [anime_tracker.py] file. I noticed some opportunities for improvement and would like to suggest the following modifications
Proposed Changes:

Modularization: The code can benefit from improved modularization. I've introduced separate functions to handle different responsibilities, making the code more readable and maintainable.

Exception Handling: by adding proper exception handling for potential errors during HTTP requests and HTML parsing, ensuring a more robust user experience.

Global Variable Elimination: The use of a global variable (soup) has been eliminated. Instead, the BeautifulSoup object is now passed between functions as a return value.

User Input Processing: User input processing has been moved to a separate function (main) for better organization, and a Keyboard Interrupt check has been added to handle program termination by the user.

Tag Presentation: Tags are now presented as a list, improving readability.

I would be happy to discuss these changes. Thank you
and let me know if it suits good

Copy link

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label gssoc23. If you're participating in GSSoC'23, please add the gssoc23 label to your issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
@avinashkranjan avinashkranjan added enhancement New feature or request good first issue Good for newcomers assigned Issues which are assigned to someone labels Dec 4, 2023
@avinashkranjan
Copy link
Owner

Go Ahead @Nancy248

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
assigned Issues which are assigned to someone enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants