Add suggestions and fixes to more rules

Fixes #281

Author: sindresorhus

docs/rules/no-duplicate-modifiers.md

@@ -4,6 +4,8 @@
 
 💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
 
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
 <!-- end auto-generated rule header -->
 
 Translations: [Français](https://github.com/avajs/ava-docs/blob/main/fr_FR/related/eslint-plugin-ava/docs/rules/no-duplicate-modifiers.md)

docs/rules/no-only-test.md

@@ -4,7 +4,7 @@
 
 💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
 
-🔧💡 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix) and manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

docs/rules/no-skip-test.md

@@ -4,7 +4,7 @@
 
 💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
 
-🔧💡 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix) and manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

docs/rules/no-todo-implementation.md

@@ -4,6 +4,8 @@
 
 💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
 
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
 <!-- end auto-generated rule header -->
 
 Translations: [Français](https://github.com/avajs/ava-docs/blob/main/fr_FR/related/eslint-plugin-ava/docs/rules/no-todo-implementation.md)

readme.md

@@ -42,10 +42,10 @@ The rules will only activate in test files.
 
 <!-- begin auto-generated rules list -->
 
-💼 Configurations enabled in.\
-⚠️ Configurations set to warn in.\
-🚫 Configurations disabled in.\
-✅ Set in the `recommended` configuration.\
+💼 [Configurations](https://github.com/avajs/eslint-plugin-ava#recommended-config) enabled in.\
+⚠️ [Configurations](https://github.com/avajs/eslint-plugin-ava#recommended-config) set to warn in.\
+🚫 [Configurations](https://github.com/avajs/eslint-plugin-ava#recommended-config) disabled in.\
+✅ Set in the `recommended` [configuration](https://github.com/avajs/eslint-plugin-ava#recommended-config).\
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
 💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 

rules/no-duplicate-modifiers.js

@@ -20,12 +20,19 @@ const create = context => {
 				return;
 			}
 
+			const {sourceCode} = context;
+
 			for (let index = 1; index < testModifiers.length; index++) {
 				if (testModifiers[index - 1].name === testModifiers[index].name) {
+					const duplicate = testModifiers[index];
 					context.report({
-						node: testModifiers[index],
+						node: duplicate,
 						messageId: MESSAGE_ID,
-						data: {name: testModifiers[index].name},
+						data: {name: duplicate.name},
+						fix(fixer) {
+							const dotToken = sourceCode.getTokenBefore(duplicate);
+							return fixer.removeRange([dotToken.range[0], duplicate.range[1]]);
+						},
 					});
 				}
 			}
@@ -42,6 +49,7 @@ export default {
 			recommended: true,
 			url: util.getDocsUrl(import.meta.filename),
 		},
+		fixable: 'code',
 		schema: [],
 		messages: {
 			[MESSAGE_ID]: 'Duplicate test modifier `.{{name}}`.',

rules/no-only-test.js

@@ -41,7 +41,6 @@ export default {
 			recommended: true,
 			url: util.getDocsUrl(import.meta.filename),
 		},
-		fixable: 'code',
 		hasSuggestions: true,
 		schema: [],
 		messages: {

rules/no-skip-test.js

@@ -41,7 +41,6 @@ export default {
 			recommended: true,
 			url: util.getDocsUrl(import.meta.filename),
 		},
-		fixable: 'code',
 		hasSuggestions: true,
 		schema: [],
 		messages: {

rules/no-todo-implementation.js

@@ -1,8 +1,11 @@
 import {visitIf} from 'enhance-visitors';
+import {isCommaToken} from '@eslint-community/eslint-utils';
 import util from '../util.js';
 import createAvaRule from '../create-ava-rule.js';
 
 const MESSAGE_ID = 'no-todo-implementation';
+const MESSAGE_ID_REMOVE_TODO = 'no-todo-implementation-remove-todo';
+const MESSAGE_ID_REMOVE_IMPLEMENTATION = 'no-todo-implementation-remove-implementation';
 
 const create = context => {
 	const ava = createAvaRule();
@@ -13,9 +16,33 @@ const create = context => {
 			ava.isTestNode,
 		])(node => {
 			if (ava.hasTestModifier('todo') && node.arguments.some(argument => util.isFunctionExpression(argument))) {
+				const {sourceCode} = context;
+				const functionArgument = node.arguments.find(argument => util.isFunctionExpression(argument));
+
 				context.report({
 					node,
 					messageId: MESSAGE_ID,
+					suggest: [
+						{
+							messageId: MESSAGE_ID_REMOVE_TODO,
+							fix: fixer => fixer.replaceTextRange(...util.removeTestModifier({
+								modifier: 'todo',
+								node,
+								context,
+							})),
+						},
+						{
+							messageId: MESSAGE_ID_REMOVE_IMPLEMENTATION,
+							fix(fixer) {
+								const commaToken = sourceCode.getTokenBefore(functionArgument, {filter: token => isCommaToken(token)});
+								if (commaToken) {
+									return fixer.removeRange([commaToken.range[0], functionArgument.range[1]]);
+								}
+
+								return fixer.remove(functionArgument);
+							},
+						},
+					],
 				});
 			}
 		}),
@@ -31,9 +58,12 @@ export default {
 			recommended: true,
 			url: util.getDocsUrl(import.meta.filename),
 		},
+		hasSuggestions: true,
 		schema: [],
 		messages: {
 			[MESSAGE_ID]: '`test.todo()` should not be passed an implementation function.',
+			[MESSAGE_ID_REMOVE_TODO]: 'Remove the `.todo` modifier to make it a regular test.',
+			[MESSAGE_ID_REMOVE_IMPLEMENTATION]: 'Remove the implementation function to keep it as a todo.',
 		},
 	},
 };

test/no-duplicate-modifiers.js

@@ -26,6 +26,7 @@ const modifiers = [
 const valid = modifiers.map(modifier => `${header}test.${modifier}(t => {});`);
 const invalid = modifiers.map(modifier => ({
 	code: `${header}test.${modifier}.${modifier}(t => {});`,
+	output: `${header}test.${modifier}(t => {});`,
 	errors: [
 		{
 			messageId: 'no-duplicate-modifiers',