Add no-invalid-modifier-chain rule

Fixes #186

Author: sindresorhus

docs/rules/no-duplicate-modifiers.md

@@ -2,7 +2,9 @@
 
 📝 Disallow duplicate test modifiers.
 
-💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
+❌ This rule is deprecated.
+
+🚫 This rule is _disabled_ in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
 
 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
 

docs/rules/no-invalid-modifier-chain.md

@@ -0,0 +1,51 @@
+# ava/no-invalid-modifier-chain
+
+📝 Disallow invalid modifier chains.
+
+💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
+
+🔧💡 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix) and manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
+<!-- end auto-generated rule header -->
+
+Translations: [Français](https://github.com/avajs/ava-docs/blob/main/fr_FR/related/eslint-plugin-ava/docs/rules/no-invalid-modifier-chain.md)
+
+AVA only allows specific [test modifier](https://github.com/avajs/ava/blob/main/docs/01-writing-tests.md) chains. Using modifiers in the wrong order, combining incompatible modifiers, or using modifiers that don't apply to a given test type will cause runtime errors.
+
+## Examples
+
+```js
+import test from 'ava';
+
+// Wrong order
+test.only.serial(t => {});  // ❌
+test.serial.only(t => {});  // ✅
+
+test.failing.serial(t => {}); // ❌
+test.serial.failing(t => {}); // ✅
+
+// Invalid combinations
+test.only.skip(t => {});  // ❌
+
+// Invalid modifiers on hooks
+test.before.failing(t => {}); // ❌
+test.before.only(t => {});    // ❌
+test.before(t => {});         // ✅
+
+// Invalid todo chains
+test.todo.failing('title'); // ❌
+test.todo('title');         // ✅
+
+// Invalid always usage
+test.before.always(t => {});    // ❌ `.always` only works with `after`/`afterEach`
+test.after.always(t => {});     // ✅
+test.afterEach.always(t => {}); // ✅
+
+// Unknown modifiers
+test.foo(t => {}); // ❌
+test.cb(t => {});  // ❌
+
+// Duplicates
+test.serial.serial(t => {}); // ❌
+test.serial(t => {});        // ✅
+```

docs/rules/no-unknown-modifiers.md

@@ -2,7 +2,9 @@
 
 📝 Disallow unknown test modifiers.
 
-💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
+❌ This rule is deprecated.
+
+🚫 This rule is _disabled_ in the ✅ `recommended` [config](https://github.com/avajs/eslint-plugin-ava#recommended-config).
 
 💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 

index.js

@@ -13,6 +13,7 @@ import noIgnoredTestFiles from './rules/no-ignored-test-files.js';
 import noImportTestFiles from './rules/no-import-test-files.js';
 import noIncorrectDeepEqual from './rules/no-incorrect-deep-equal.js';
 import noInlineAssertions from './rules/no-inline-assertions.js';
+import noInvalidModifierChain from './rules/no-invalid-modifier-chain.js';
 import noNestedAssertions from './rules/no-nested-assertions.js';
 import noNestedTests from './rules/no-nested-tests.js';
 import noOnlyTest from './rules/no-only-test.js';
@@ -51,6 +52,7 @@ const rules = {
 	'no-import-test-files': noImportTestFiles,
 	'no-incorrect-deep-equal': noIncorrectDeepEqual,
 	'no-inline-assertions': noInlineAssertions,
+	'no-invalid-modifier-chain': noInvalidModifierChain,
 	'no-nested-assertions': noNestedAssertions,
 	'no-nested-tests': noNestedTests,
 	'no-only-test': noOnlyTest,
@@ -83,20 +85,21 @@ const recommendedRules = {
 	],
 	'ava/no-async-fn-without-await': 'error',
 	'ava/no-commented-tests': 'warn',
-	'ava/no-duplicate-modifiers': 'error',
+	'ava/no-duplicate-modifiers': 'off',
 	'ava/no-identical-title': 'error',
 	'ava/no-ignored-test-files': 'error',
 	'ava/no-import-test-files': 'error',
 	'ava/no-incorrect-deep-equal': 'error',
 	'ava/no-inline-assertions': 'error',
+	'ava/no-invalid-modifier-chain': 'error',
 	'ava/no-nested-assertions': 'error',
 	'ava/no-nested-tests': 'error',
 	'ava/no-only-test': 'error',
 	'ava/no-skip-assert': 'error',
 	'ava/no-skip-test': 'error',
 	'ava/no-todo-implementation': 'error',
 	'ava/no-todo-test': 'warn',
-	'ava/no-unknown-modifiers': 'error',
+	'ava/no-unknown-modifiers': 'off',
 	'ava/no-useless-t-pass': 'error',
 	'ava/prefer-async-await': 'error',
 	'ava/prefer-power-assert': 'off',