You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.
Trying to submit an invalid run number (i.e. a range 123-130) should show a front-end warning. It seems the input field blocks some characters from being entered, but - is still allowed (perhaps for negative numbers). The minimum run number value (the run number of the ReductionRun.objects.last().run_number) is also not respected when typing, only when clicking the up/down arrows on the right side of the field. This validation should be done in JavaScript.
If it is submitted anyway, the configure_new_runs_post should show the error message in a nicer way - as a message on the configure_new_runs.html, with the fields filled with the user’s submission values. This validation should be done in the Python view.
Actual behaviour
There’s no form validation, and a crude “Invalid” message is shown.
Suggested verification/testing steps
e.g.
Run webapp
Go to instrument page and click Configure New Runs
Enter 123-345 in run number field and click submit
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behaviour
Trying to submit an invalid run number (i.e. a range 123-130) should show a front-end warning. It seems the input field blocks some characters from being entered, but
-
is still allowed (perhaps for negative numbers). The minimum run number value (the run number of theReductionRun.objects.last().run_number
) is also not respected when typing, only when clicking the up/down arrows on the right side of the field. This validation should be done in JavaScript.If it is submitted anyway, the
configure_new_runs_post
should show the error message in a nicer way - as a message on theconfigure_new_runs.html
, with the fields filled with the user’s submission values. This validation should be done in the Python view.Actual behaviour
There’s no form validation, and a crude “Invalid” message is shown.
Suggested verification/testing steps
e.g.
Run webapp
Go to instrument page and click Configure New Runs
Enter 123-345 in run number field and click submit
The text was updated successfully, but these errors were encountered: