Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

reduction_viewer.urls inconsistent instrument name parameter #186

Open
Pasarus opened this issue Aug 18, 2022 · 0 comments
Open

reduction_viewer.urls inconsistent instrument name parameter #186

Pasarus opened this issue Aug 18, 2022 · 0 comments

Comments

@Pasarus
Copy link
Member

Pasarus commented Aug 18, 2022

Issue raised by: [developer/user/project requirement]

What?

path('<str:instrument>/', views.runs_list, name='list'),
path('<str:instrument_name>/<int:run_number>/', views.run_summary, name='summary'),
path('<str:instrument_name>/<int:run_number>/<int:run_version>/', views.run_summary, name='summary'),

In the first one the instrument name is passed with the variable name instrument, but in the other 2 with the name instrument_name. This makes the URL reverses to runs:... inconsistent.

Pick one and stick to it!

Where?
WebApp/autoreduce_webapp/reduction_viewer/urls.py

then grep for runs:summary and fix all the reverse and url calls (15 results as of issue creation)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant