-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of "munki_repo_changed" to detect the need of makecatalog #418
Comments
That's a neat idea and I'd love to see your implementation in a PR.
…On Wed, Mar 9, 2022 at 8:38 AM Matthias Choules ***@***.***> wrote:
The MakeCatalogsProcessor checks the AutoPKG results, if a MunkiImporter
has imported an item:
https://github.com/autopkg/recipes/blob/b575ed8e1621b8bf88a3a847d9792c2c1a0b85a7/Munki/MakeCatalogsProcessor.py#L75
Since "import" is not the only action which may modify the repository, it
would be great to check for the processor output "munki_repo_changed",
which seems to be more generic.
Background:
We are currently working on a processor, which may modify some pkginfo
files, even though no new items have been imported. It would be great to
have the option to rebuild the catalogs using the MakeCatalogs.munki recipe
afterwards.
I would be happy to provide a pull request, if this has a chance to be
integrated.
—
Reply to this email directly, view it on GitHub
<#418>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJFTX7PWERGWYGHVXPC3ATU7DHYLANCNFSM5QKCMAGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
--
Nick McSpadden
***@***.***
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The MakeCatalogsProcessor checks the AutoPKG results, if a MunkiImporter has imported an item:
recipes/Munki/MakeCatalogsProcessor.py
Line 75 in b575ed8
Since "import" is not the only action which may modify the repository, it would be great to check for the processor output munki_repo_changed, which seems to be more generic.
Background:
We are currently working on a processor, which may modify some pkginfo files, even though no new items have been imported. It would be great to have the option to rebuild the catalogs using the MakeCatalogs.munki recipe afterwards.
I would be happy to provide a pull request, if this has a chance to be integrated.
The text was updated successfully, but these errors were encountered: