Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize "--replSet" via environment variable instead of command #6

Open
tianon opened this issue Dec 9, 2016 · 1 comment

Comments

@tianon
Copy link
Contributor

tianon commented Dec 9, 2016

Currently, to modify the value of --replSet, one has to replace the entire image command, ala:

command: containerpilot mongod --replSet=pilot

        command: containerpilot mongod --replSet=pilot

This is a bit fragile for users who might want to specify not only a custom --replSet, but possibly also other mongod arguments, especially if we end up needing to change the default image command at some point too (for whatever reason).

It'd be nice if this could be specified somehow via environment variable to override the current default value of joyent to avoid these issues (although that does get us into a bit of a catch-22 with TritonDataCenter/containerpilot#126 -- possibly most easily solved via a short wrapper script to run in front of/in place of mongod).

@leoj3n
Copy link

leoj3n commented Apr 26, 2019

I think your env var recommendation has been implemented, which is why I made PR #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants