Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support golang autofix #8

Open
gengjiawen opened this issue Mar 12, 2021 · 4 comments · May be fixed by #9
Open

support golang autofix #8

gengjiawen opened this issue Mar 12, 2021 · 4 comments · May be fixed by #9

Comments

@gengjiawen
Copy link

No description provided.

@jankeromnes
Copy link
Member

Using https://github.com/golangci/golangci-lint ? Excellent idea! 💯 Thanks for the suggestion

@gengjiawen
Copy link
Author

My first intension is to auto uggrade go version https://github.com/gitpod-io/workspace-images/blob/81a67e22ec616fcf2f102541e8ceb6dcf929c213/full/Dockerfile#L78.

But if we have both, also works for me :)

@jankeromnes
Copy link
Member

Aha, great idea too! I think we need both. 👍

Also, the Go version itself isn't really a module, but note that there is already https://github.com/autofix-dev/autofix/blob/master/fixers/upgrade-go-modules.js (which just auto-upgrades gopls for now). Please feel free to make it also upgrade any outdated-looking GO_VERSION, or to implement a separate fixer for that.

Also please let me know if you'd like any help! I'm happy to help make this happen. 🚀

@gengjiawen
Copy link
Author

Where can I get the latest version number of golang, the way I find best is https://golang.org/dl/. But looks like we need to parse version from the html.

@gengjiawen gengjiawen linked a pull request Aug 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants