-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CockroachDB index should to store caveats #1923
Comments
This can also be applied to our reverse index, too |
I just made a pull request (#1988) and I’m seeking some clarification on how this change can enhance the check performance. From my understanding, there is only one type of SQL query used in the check request, and its WHERE condition is the same as the new index. Would a standard index suffice to improve the query speed? Additionally, could you please explain why STORING (caveat_name, caveat_context); is necessary? Thank you for your assistance! |
Problem Statement
A production system recommended the following index:
CREATE INDEX ON relation_tuple (namespace, relation, object_id, userset_relation) STORING (caveat_name, caveat_context);
Solution Brainstorm
This is the closest to our primary key constraint and should improve overall check performance.
The text was updated successfully, but these errors were encountered: