Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacebar Play/Pause doesn't work correctly on Firefox 88.0.1 #67

Open
tjueterb opened this issue Jun 1, 2021 · 3 comments
Open

Spacebar Play/Pause doesn't work correctly on Firefox 88.0.1 #67

tjueterb opened this issue Jun 1, 2021 · 3 comments
Labels

Comments

@tjueterb
Copy link

tjueterb commented Jun 1, 2021

Hey guys,

play/pause gets triggered when pressing and when releasing the spacebar on Firefox 88.0.1

I didn't notice the issue on other browsers.

@faroit
Copy link
Collaborator

faroit commented Jun 1, 2021

probably some issue with the keyboard shortcut lib we are using. the version inside webMUSHRA seems horribly outdated: https://github.com/ccampbell/mousetrap

I don't have the bandwidth to change this right now, but feel free to open a PR, replacing https://github.com/audiolabs/webMUSHRA/tree/master/lib/external/mousetrap with the newest version and test if this solves it...

@faroit faroit added the bug label Jun 1, 2021
@tjueterb
Copy link
Author

tjueterb commented Jun 1, 2021

I replaced both files (LICENSE.txt and mousetrap.min.js) with the updated versions but it did not solve the issue for me, do you still want me to open a PR?

@faroit
Copy link
Collaborator

faroit commented Jun 3, 2021

@tjueterb Lets maybe wait until the issue is fixed. Can you raise an issue at mousetrap or try to reproduce it in a demo site?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants