Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix SIP Go Code Style Issues #18

Open
lb4368 opened this issue Dec 4, 2020 · 4 comments
Open

Fix SIP Go Code Style Issues #18

lb4368 opened this issue Dec 4, 2020 · 4 comments
Assignees

Comments

@lb4368
Copy link

lb4368 commented Dec 4, 2020

Need to address linter warnings identified with code comments, variable names, etc. and remove commented lines of code in SIP POC code, so that code/comment style matches best practice.

@lb4368 lb4368 changed the title Fix Go Code Comment Style Issues Fix SIP Go Code Style Issues Dec 4, 2020
@ian-howell ian-howell self-assigned this Dec 7, 2020
@ian-howell
Copy link
Contributor

I don't know that this has a clear closing criteria since code stewarding is an ongoing process, but I'll go ahead and take some time to clean things up.

@teoyaomiqui
Copy link
Collaborator

I don't know that this has a clear closing criteria since code stewarding is an ongoing process, but I'll go ahead and take some time to clean things up.

i would say closing criteria is to add a target in make file that would run reasonable lint tests, and code passes them

@lb4368
Copy link
Author

lb4368 commented Dec 7, 2020

I don't know that this has a clear closing criteria since code stewarding is an ongoing process, but I'll go ahead and take some time to clean things up.

i would say closing criteria is to add a target in make file that would run reasonable lint tests, and code passes them

Yes, closing criteria for this is for the current version of code to pass lint tests. It should be an on-going acceptance criteria for new features. There is also a https://itrack.web.att.com/browse/CPVYGR-94 story in iTrack to add lint to the build.

@ian-howell
Copy link
Contributor

Closing criteria will be met via #21, although I am going to continue fixing some style/spelling/formatting issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants