You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Need to address linter warnings identified with code comments, variable names, etc. and remove commented lines of code in SIP POC code, so that code/comment style matches best practice.
The text was updated successfully, but these errors were encountered:
lb4368
changed the title
Fix Go Code Comment Style Issues
Fix SIP Go Code Style Issues
Dec 4, 2020
I don't know that this has a clear closing criteria since code stewarding is an ongoing process, but I'll go ahead and take some time to clean things up.
I don't know that this has a clear closing criteria since code stewarding is an ongoing process, but I'll go ahead and take some time to clean things up.
i would say closing criteria is to add a target in make file that would run reasonable lint tests, and code passes them
I don't know that this has a clear closing criteria since code stewarding is an ongoing process, but I'll go ahead and take some time to clean things up.
i would say closing criteria is to add a target in make file that would run reasonable lint tests, and code passes them
Yes, closing criteria for this is for the current version of code to pass lint tests. It should be an on-going acceptance criteria for new features. There is also a https://itrack.web.att.com/browse/CPVYGR-94 story in iTrack to add lint to the build.
Need to address linter warnings identified with code comments, variable names, etc. and remove commented lines of code in SIP POC code, so that code/comment style matches best practice.
The text was updated successfully, but these errors were encountered: