Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update user profile #53

Merged
merged 1 commit into from
May 17, 2024
Merged

update user profile #53

merged 1 commit into from
May 17, 2024

Conversation

Dawaic6
Copy link
Contributor

@Dawaic6 Dawaic6 commented May 8, 2024

This pull request introduces a new feature that allows users, both vendors and buyers, to update their profile information through an API endpoint. Users can modify details such as their name, email, and other relevant information to ensure their account remains accurate and up-to-date.

Implemented Features:

-User Profile Update API Endpoint: Implement an API endpoint /api/v1/updateProfile for users to update their profile information.
-Error Handling and Responses: Implement appropriate error handling mechanisms to handle edge cases and provide informative responses to users.

Definition of Done:

  • acceptance criteria .
  • Unit tests .
  • API documentation is included.

Related Issues:
#28

To use the Code

Screenshot

-for test
image
-for swagger
image

@Dawaic6 Dawaic6 changed the title pull from develop update user profile May 9, 2024
@Dawaic6 Dawaic6 self-assigned this May 9, 2024
@Dawaic6 Dawaic6 added backend Good for newcomers WIP Work In Progress labels May 9, 2024
@Dawaic6 Dawaic6 added this to the Authentication & RBAC milestone May 9, 2024
@Dawaic6 Dawaic6 linked an issue May 9, 2024 that may be closed by this pull request
5 tasks
@Dawaic6 Dawaic6 force-pushed the ft-Profile_Update-#35 branch 3 times, most recently from bfd6164 to da29113 Compare May 9, 2024 18:44
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It look good for me!!!

wayneleon1
wayneleon1 previously approved these changes May 10, 2024
Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

13XAVI
13XAVI previously approved these changes May 10, 2024
Copy link
Contributor

@13XAVI 13XAVI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

bertrandshema
bertrandshema previously approved these changes May 10, 2024
Copy link
Contributor

@bertrandshema bertrandshema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

src/controller/userController.ts Outdated Show resolved Hide resolved
src/routes/userRoutes.ts Outdated Show resolved Hide resolved
src/controller/userController.ts Outdated Show resolved Hide resolved
src/controller/userController.ts Outdated Show resolved Hide resolved
@Dawaic6 Dawaic6 dismissed stale reviews from bertrandshema, 13XAVI, and wayneleon1 via c00550d May 14, 2024 15:01
@Dawaic6 Dawaic6 force-pushed the ft-Profile_Update-#35 branch 2 times, most recently from 4751b7d to 825b824 Compare May 17, 2024 07:40
* squashing commits

implementing routes for auth

create passport callback function

adding new user from Google

creating new user

check if user is exist in db

implementing cookie session

Fix error of TypeError: req.session.regenerate is not a function using Passport

fix secret keys

remove Google client secret keys

working on facebook strategy

get email from fb login and update the scope

after verification save the user into db

add profile image in db

fixing minor bugs

fix minor bugs in codes

after rebasing & updating some fts

link social login with userModel

Addong Google client keys & FB client key into yml

send confrim email after register a new user

send email after register from facebook

fix minor bugs

* fix minor errors

* remove lints errors

user register

register user test

register user testing fix

register user testing fix

register user testing fix

Authentication for User

Added slint changes

removed  mocha

 added new features

 added new features

Solved comflicts

changed file

added changes

added new Test

added new Test

resolved test cases

resolved test cases

implemented two-factor authentication for enhanced security

implemented two-factor authentication for enhanced security

check whether the usertype is vendor to proceed with 2FA

test the 2fa authentication

pull from develop

update profile test

update swagger documentation

Resolve conflict on update profile

fix issue mentioned in comment

fix test issue

fix test issues

fix CI
@Dawaic6 Dawaic6 requested review from wayneleon1 and 13XAVI May 17, 2024 07:55
Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's look good

Copy link
Contributor

@bertrandshema bertrandshema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay with me

Copy link
Collaborator

@Habinezajanvier Habinezajanvier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Habinezajanvier Habinezajanvier merged commit c6afdde into develop May 17, 2024
3 checks passed
ambroisegithub pushed a commit that referenced this pull request May 17, 2024
ambroisegithub pushed a commit that referenced this pull request May 17, 2024
@Dawaic6 Dawaic6 deleted the ft-Profile_Update-#35 branch May 17, 2024 17:15
ambroisegithub pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: User Profile Update
6 participants