Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] support #93

Open
lorenzomigliorero opened this issue Nov 15, 2018 · 6 comments
Open

[email protected] support #93

lorenzomigliorero opened this issue Nov 15, 2018 · 6 comments

Comments

@lorenzomigliorero
Copy link

Is there any intention to support [email protected]?
Currently, when launch lerna-semantic-release pre i obtain this error:

Error: Cannot find module 'lerna/lib/Repository'

@renanbronchart
Copy link

I have the same problem, Do you have any roadmap on this subject?

Thanks a lot.

@lukebatchelor
Copy link
Member

It should be as simple as bumping cz-lerna-changelog in here, and also the Lerna dep to a non--prerelease.

I'm not able to test that ATM, but if anyone is able to take a look, I'm happy to test and merge it

@silouanwright
Copy link

silouanwright commented Mar 2, 2019

@lukebatchelor that unfortunately wouldn't be enough, upon testing. The lerna/lib/Repository error that was cited, is coming from the lerna-semantic-release-io package in the monorepo.

I'm attempting to try to fix but I'm not "100%" sure I'll be able to. I'll give it a shot though.

silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
silouanwright added a commit to silouanwright/lerna-semantic-release that referenced this issue Mar 2, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
@silouanwright
Copy link

silouanwright commented Mar 4, 2019

@lukebatchelor I got as far as I could I think. My PR is referenced above. Essentially, updating those 2 things you mentioned wasn't enough.

https://github.com/atlassian/cz-lerna-changelog/pull/17/files

There were some changes I found in this PR, that probably need to make it's way here as well. So I made updates, ran tests, tried to fix things further. Could definitely use some help from anyone to push this past the finish line.

@CowDotDev
Copy link

Just bumping to see what the status of this is... I may just end up using @reywright's fork to see if we can't get a working version. Though, this should absolutely be something fixed here.

@CowDotDev
Copy link

CowDotDev commented Sep 24, 2019

I created a fork with the changes I had to make to get Lerna 3.x support, I also fixed the broken tests. #97

Shout out to @reywright for starting the investigation :) had a huge head start thanks to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants