Moving models to a separate directory and standardizing the use of config object #84
Labels
priority: high
High priority, should be address immediately
topic: processors
Issues related to design and development of processors
The current NER and SRL processors (including the NER trainer) are not efficiently designed. Particularly, in the
initialize
method, we create a model and use config object in a non-standard way. That is, we do not follow any pattern on how to access theconfig
object. Also, creating the model inside theinitialize
makes the processor to be tightly coupled with that model and hence to use a different model, we need to tweak theinitialize
method. This defeats the purpose of reusable processor. This issue is created to address the followingCreate a directory of models like for e.g.,
BiRecurrentConvCRF
,LabeledSpanGraphNetwork
etc. The processors should import the models defined here based on a value in configs passed to the initialize method.Standardize a way to use config object. Each processor is currently using
config
object in its own way which will lead lot of repetitiveness and unnecessary complications. To address this issue, we need to ensure a set of standard keys to use for most common configurations likemodel_path
,resource_dir
etc. This, however, does not restrict the user to follow this pattern but introduces a principled way to use theconfig
object.The text was updated successfully, but these errors were encountered: