Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving models to a separate directory and standardizing the use of config object #84

Open
AvinashBukkittu opened this issue Nov 15, 2019 · 0 comments
Labels
priority: high High priority, should be address immediately topic: processors Issues related to design and development of processors

Comments

@AvinashBukkittu
Copy link
Collaborator

The current NER and SRL processors (including the NER trainer) are not efficiently designed. Particularly, in the initialize method, we create a model and use config object in a non-standard way. That is, we do not follow any pattern on how to access the config object. Also, creating the model inside the initialize makes the processor to be tightly coupled with that model and hence to use a different model, we need to tweak the initialize method. This defeats the purpose of reusable processor. This issue is created to address the following

  1. Create a directory of models like for e.g., BiRecurrentConvCRF, LabeledSpanGraphNetwork etc. The processors should import the models defined here based on a value in configs passed to the initialize method.

  2. Standardize a way to use config object. Each processor is currently using config object in its own way which will lead lot of repetitiveness and unnecessary complications. To address this issue, we need to ensure a set of standard keys to use for most common configurations like model_path, resource_dir etc. This, however, does not restrict the user to follow this pattern but introduces a principled way to use the config object.

@AvinashBukkittu AvinashBukkittu added the topic: processors Issues related to design and development of processors label Nov 15, 2019
@hunterhector hunterhector added the priority: high High priority, should be address immediately label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority, should be address immediately topic: processors Issues related to design and development of processors
Projects
None yet
Development

No branches or pull requests

2 participants