Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StanfordNLP sentence segmenter bug #152

Closed
atif93 opened this issue Feb 3, 2020 · 2 comments
Closed

StanfordNLP sentence segmenter bug #152

atif93 opened this issue Feb 3, 2020 · 2 comments
Assignees
Labels
bug Something isn't working priority: medium topic: processors Issues related to design and development of processors

Comments

@atif93
Copy link
Collaborator

atif93 commented Feb 3, 2020

While trying to find sentence boundaries, the technique to find the sentence ending can fail.
We are using find which gives the first occurrence of a word in a sentence. This will definitely fail when there are 2 duplicate words in a sentence.

https://github.com/asyml/forte/blob/master/forte/processors/stanfordnlp_processor.py#L72

@atif93 atif93 added the bug Something isn't working label Feb 3, 2020
@hunterhector
Copy link
Member

Thanks for spotting this. Let's try to add the failure cases to tests, and come up with a universal solution for such cases.

@hunterhector hunterhector added priority: medium topic: processors Issues related to design and development of processors labels Jul 5, 2020
@hunterhector
Copy link
Member

Will close this and solve problems using a universal solution #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium topic: processors Issues related to design and development of processors
Projects
None yet
Development

No branches or pull requests

3 participants