Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic of query processing is not straightforward #107

Open
hunterhector opened this issue Jan 3, 2020 · 0 comments
Open

Logic of query processing is not straightforward #107

hunterhector opened this issue Jan 3, 2020 · 0 comments
Labels
priority: low Low priority, can be addressed later topic: interface The design and implementation of the Forte interface

Comments

@hunterhector
Copy link
Member

In an attempt to simplify the user's implementation of creating Query, we implement some logic into process, but since we are dealing with multipacks, we do not know beforehand where the query should be inserted. Thus in the _process_query logic, we ask the users to return the specific pack to store the query. This logic is tricky to understand for developers. Probably even allowing the developer to handle all the query creation might be easier.

See discussion:
#103 (comment)
@hunterhector hunterhector added the topic: interface The design and implementation of the Forte interface label Jan 3, 2020
@hunterhector hunterhector added the priority: low Low priority, can be addressed later label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low Low priority, can be addressed later topic: interface The design and implementation of the Forte interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hunterhector