Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments soft deletion #162

Open
riggraz opened this issue Oct 24, 2022 · 1 comment
Open

Comments soft deletion #162

riggraz opened this issue Oct 24, 2022 · 1 comment
Labels
discussion Issues or pull requests that need discussion in order to reach an agreement feature New feature or request ruby Issues that require ruby knowledge and pull requests that update Ruby code

Comments

@riggraz
Copy link
Collaborator

riggraz commented Oct 24, 2022

Deleting a parent comment should not result in the deletion of all child comments. In order to avoid that, comment deletion should be a soft delete, so instead of destroying the record in the database just change a flag column on it.

For example, a is_deleted flag could be added to comments, so that when it is false the comment is not deleted, when it is set to true the comment is considered deleted.
@riggraz riggraz added feature New feature or request ruby Issues that require ruby knowledge and pull requests that update Ruby code labels Oct 24, 2022
@riggraz riggraz added this to the v 1.0 milestone Oct 25, 2022
@riggraz riggraz self-assigned this Jan 10, 2023
@riggraz
Copy link
Collaborator Author

riggraz commented Jan 10, 2023

Is it really necessary? If a comments gets deleted (by author or by administrators) then all its children comments would remain available, but the context given by the deleted parent comment is lost.

@riggraz riggraz removed this from the v 1.0 milestone Jan 10, 2023
@riggraz riggraz added the discussion Issues or pull requests that need discussion in order to reach an agreement label Jan 10, 2023
@riggraz riggraz removed their assignment Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Issues or pull requests that need discussion in order to reach an agreement feature New feature or request ruby Issues that require ruby knowledge and pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riggraz