Resolve all eslint warnings (apache#48197)

bbovenzi · Sneha Prabhu · commit d5b269174cb0 · 2025-03-25T12:09:53.000+05:30
diff --git a/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx b/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx
@@ -48,8 +48,7 @@ export const FieldDateTime = ({ name, ...rest }: FlexibleFormElementProps & Inpu
       onChange={(event) => handleChange(event.target.value)}
       size="sm"
       type={rest.type}
-      // eslint-disable-next-line @typescript-eslint/no-base-to-string
-      value={param.value !== null && param.value !== undefined ? String(param.value).slice(0, 16) : ""}
+      value={JSON.stringify(param.value ?? "").slice(0, 16)}
     />
   );
 };
diff --git a/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldMultilineText.tsx b/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldMultilineText.tsx
@@ -42,8 +42,7 @@ export const FieldMultilineText = ({ name }: FlexibleFormElementProps) => {
       onChange={(event) => handleChange(event.target.value)}
       rows={6}
       size="sm"
-      // eslint-disable-next-line @typescript-eslint/no-base-to-string
-      value={String(param.value ?? "")}
+      value={JSON.stringify(param.value ?? "")}
     />
   );
 };
diff --git a/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldNumber.tsx b/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldNumber.tsx
@@ -51,8 +51,7 @@ export const FieldNumber = ({ name }: FlexibleFormElementProps) => {
       name={`element_${name}`}
       onValueChange={(event) => handleChange(event.value)}
       size="sm"
-      // eslint-disable-next-line @typescript-eslint/no-base-to-string
-      value={String(param.value ?? "")}
+      value={JSON.stringify(param.value ?? "")}
     >
       <NumberInputField />
     </NumberInputRoot>
diff --git a/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldString.tsx b/airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldString.tsx
@@ -48,8 +48,7 @@ export const FieldString = ({ name }: FlexibleFormElementProps) => {
         }}
         placeholder={param.schema.examples ? "Start typing to see options." : undefined}
         size="sm"
-        // eslint-disable-next-line @typescript-eslint/no-base-to-string
-        value={String(param.value ?? "")}
+        value={JSON.stringify(param.value ?? "")}
       />
       {param.schema.examples ? (
         <datalist id={`list_${name}`}>
diff --git a/airflow-core/src/airflow/ui/src/components/FlexibleForm/HiddenInput.tsx b/airflow-core/src/airflow/ui/src/components/FlexibleForm/HiddenInput.tsx
@@ -33,8 +33,7 @@ export const HiddenInput = ({ name }: FlexibleFormElementProps) => {
         id={`element_${name}`}
         name={`element_${name}`}
         type="hidden"
-        // eslint-disable-next-line @typescript-eslint/no-base-to-string
-        value={String(param.value ?? "")}
+        value={JSON.stringify(param.value ?? "")}
       />
     </VisuallyHidden>
   );
diff --git a/airflow-core/src/airflow/ui/src/components/ui/Menu/Menu.tsx b/airflow-core/src/airflow/ui/src/components/ui/Menu/Menu.tsx
@@ -0,0 +1,26 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Menu as ChakraMenu } from "@chakra-ui/react";
+
+import { Content } from "./MenuContent";
+
+export const Menu = {
+  ...ChakraMenu,
+  Content,
+};
diff --git a/airflow-core/src/airflow/ui/src/components/ui/Menu/MenuContent.tsx b/airflow-core/src/airflow/ui/src/components/ui/Menu/MenuContent.tsx
@@ -24,7 +24,7 @@ type MenuContentProps = {
   readonly portalRef?: React.RefObject<HTMLElement>;
 } & ChakraMenu.ContentProps;
 
-const Content = forwardRef<HTMLDivElement, MenuContentProps>((props, ref) => {
+export const Content = forwardRef<HTMLDivElement, MenuContentProps>((props, ref) => {
   const { portalled = true, portalRef, ...rest } = props;
 
   return (
@@ -35,8 +35,3 @@ const Content = forwardRef<HTMLDivElement, MenuContentProps>((props, ref) => {
     </Portal>
   );
 });
-
-export const Menu = {
-  ...ChakraMenu,
-  Content,
-};
diff --git a/airflow-core/src/airflow/ui/src/components/ui/Menu/index.ts b/airflow-core/src/airflow/ui/src/components/ui/Menu/index.ts
@@ -0,0 +1,20 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export * from "./Menu";
diff --git a/airflow-core/src/airflow/ui/src/components/ui/Toaster/Toaster.tsx b/airflow-core/src/airflow/ui/src/components/ui/Toaster/Toaster.tsx
@@ -16,12 +16,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { Toaster as ChakraToaster, Portal, Spinner, Stack, Toast, createToaster } from "@chakra-ui/react";
+import { Toaster as ChakraToaster, Portal, Spinner, Stack, Toast } from "@chakra-ui/react";
 
-export const toaster = createToaster({
-  pauseOnPageIdle: true,
-  placement: "bottom-end",
-});
+import { toaster } from "./createToaster";
 
 export const Toaster = () => (
   <Portal>
diff --git a/airflow-core/src/airflow/ui/src/components/ui/Toaster/createToaster.ts b/airflow-core/src/airflow/ui/src/components/ui/Toaster/createToaster.ts
@@ -0,0 +1,24 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { createToaster } from "@chakra-ui/react";
+
+export const toaster = createToaster({
+  pauseOnPageIdle: true,
+  placement: "bottom-end",
+});
diff --git a/airflow-core/src/airflow/ui/src/components/ui/Toaster/index.ts b/airflow-core/src/airflow/ui/src/components/ui/Toaster/index.ts
@@ -0,0 +1,21 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export * from "./Toaster";
+export * from "./createToaster";
diff --git a/airflow-core/src/airflow/ui/src/context/openGroups/Context.ts b/airflow-core/src/airflow/ui/src/context/openGroups/Context.ts
@@ -0,0 +1,27 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { createContext } from "react";
+
+export type OpenGroupsContextType = {
+  openGroupIds: Array<string>;
+  setOpenGroupIds: (groupIds: Array<string>) => void;
+  toggleGroupId: (groupId: string) => void;
+};
+
+export const OpenGroupsContext = createContext<OpenGroupsContextType | undefined>(undefined);
diff --git a/airflow-core/src/airflow/ui/src/context/openGroups/OpenGroupsProvider.tsx b/airflow-core/src/airflow/ui/src/context/openGroups/OpenGroupsProvider.tsx
@@ -16,16 +16,10 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { createContext, useCallback, useMemo, type PropsWithChildren } from "react";
+import { useCallback, useMemo, type PropsWithChildren } from "react";
 import { useLocalStorage } from "usehooks-ts";
 
-export type OpenGroupsContextType = {
-  openGroupIds: Array<string>;
-  setOpenGroupIds: (groupIds: Array<string>) => void;
-  toggleGroupId: (groupId: string) => void;
-};
-
-export const OpenGroupsContext = createContext<OpenGroupsContextType | undefined>(undefined);
+import { OpenGroupsContext, type OpenGroupsContextType } from "./Context";
 
 type Props = {
   readonly dagId: string;
diff --git a/airflow-core/src/airflow/ui/src/context/openGroups/index.ts b/airflow-core/src/airflow/ui/src/context/openGroups/index.ts
@@ -19,3 +19,4 @@
 
 export * from "./OpenGroupsProvider";
 export * from "./useOpenGroups";
+export * from "./Context";
diff --git a/airflow-core/src/airflow/ui/src/context/openGroups/useOpenGroups.ts b/airflow-core/src/airflow/ui/src/context/openGroups/useOpenGroups.ts
@@ -18,7 +18,7 @@
  */
 import { useContext } from "react";
 
-import { OpenGroupsContext, type OpenGroupsContextType } from "./OpenGroupsProvider";
+import { OpenGroupsContext, type OpenGroupsContextType } from "./Context";
 
 export const useOpenGroups = (): OpenGroupsContextType => {
   const context = useContext(OpenGroupsContext);
diff --git a/airflow-core/src/airflow/ui/src/context/timezone/Context.ts b/airflow-core/src/airflow/ui/src/context/timezone/Context.ts
@@ -0,0 +1,26 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { createContext } from "react";
+
+export type TimezoneContextType = {
+  selectedTimezone: string;
+  setSelectedTimezone: (timezone: string) => void;
+};
+
+export const TimezoneContext = createContext<TimezoneContextType | undefined>(undefined);
diff --git a/airflow-core/src/airflow/ui/src/context/timezone/TimezoneProvider.tsx b/airflow-core/src/airflow/ui/src/context/timezone/TimezoneProvider.tsx
@@ -16,17 +16,12 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { createContext, useMemo, type PropsWithChildren } from "react";
+import { useMemo, type PropsWithChildren } from "react";
 import { useLocalStorage } from "usehooks-ts";
 
 import { useConfig } from "src/queries/useConfig";
 
-export type TimezoneContextType = {
-  selectedTimezone: string;
-  setSelectedTimezone: (timezone: string) => void;
-};
-
-export const TimezoneContext = createContext<TimezoneContextType | undefined>(undefined);
+import { TimezoneContext, type TimezoneContextType } from "./Context";
 
 const TIMEZONE_KEY = "timezone";
 
diff --git a/airflow-core/src/airflow/ui/src/context/timezone/index.ts b/airflow-core/src/airflow/ui/src/context/timezone/index.ts
@@ -19,3 +19,4 @@
 
 export * from "./TimezoneProvider";
 export * from "./useTimezone";
+export * from "./Context";
diff --git a/airflow-core/src/airflow/ui/src/context/timezone/useTimezone.ts b/airflow-core/src/airflow/ui/src/context/timezone/useTimezone.ts
@@ -18,7 +18,7 @@
  */
 import { useContext } from "react";
 
-import { TimezoneContext, type TimezoneContextType } from "./TimezoneProvider";
+import { TimezoneContext, type TimezoneContextType } from "./Context";
 
 export const useTimezone = (): TimezoneContextType => {
   const context = useContext(TimezoneContext);
diff --git a/airflow-core/src/airflow/ui/src/pages/TaskInstance/RenderedTemplates.tsx b/airflow-core/src/airflow/ui/src/pages/TaskInstance/RenderedTemplates.tsx
@@ -38,8 +38,7 @@ export const RenderedTemplates = () => {
         <Table.Body>
           {Object.entries(taskInstance?.rendered_fields ?? {}).map(([key, value]) => {
             if (value !== null && value !== undefined) {
-              // eslint-disable-next-line @typescript-eslint/no-base-to-string
-              const renderedValue: string = typeof value === "object" ? JSON.stringify(value) : String(value);
+              const renderedValue = JSON.stringify(value);
 
               return (
                 <Table.Row key={key}>
