Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to pass create_temp_table: False to SqlAlchemy? #112

Open
kujaska opened this issue Jun 19, 2023 · 3 comments
Open

How to pass create_temp_table: False to SqlAlchemy? #112

kujaska opened this issue Jun 19, 2023 · 3 comments
Assignees

Comments

@kujaska
Copy link

kujaska commented Jun 19, 2023

When using great expectations with datasources from great_expectations.yml you can use

  create_temp_table: False

setting for SqlAlchemyExecutionEngine to prevent SqlAlchemy from issuing SQLs like this:

CREATE OR REPLACE TEMPORARY TABLE gx_temp_d5435 AS select ...

Question:
How to do the same if using airflow-provider-great-expectations with Airflow conn_id (which overrides datasources from great_expectations.yml)?

@aaguilarguero
Copy link

Hi, may I know where this is in the priority list. I ran across this issue on my end and it would be great to have this functionality. Thanks!

antelmoa added a commit to antelmoa/airflow-provider-great-expectations that referenced this issue Feb 1, 2024
@antelmoa
Copy link
Contributor

antelmoa commented Feb 1, 2024

Hi again, I ended up giving this a try to add support for it. Would appreciate any eyes on this. TIA!

@Lee-W
Copy link
Contributor

Lee-W commented Feb 2, 2024

Sure! Sorry for the late reply. will take a look today

pankajastro added a commit that referenced this issue Feb 2, 2024
* #112: add create_temp_table support

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update great_expectations_provider/operators/great_expectations.py

Co-authored-by: Wei Lee <[email protected]>

* Update great_expectations_provider/operators/great_expectations.py

Co-authored-by: Wei Lee <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Pankaj Singh <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants