Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide snapshot tests for storage values in sequencer #1982

Open
Fraser999 opened this issue Feb 19, 2025 · 0 comments
Open

Provide snapshot tests for storage values in sequencer #1982

Fraser999 opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
code-quality sequencer pertaining to the astria-sequencer crate testing

Comments

@Fraser999
Copy link
Contributor

We need to ensure new variants of the many <component>::storage::ValueImpl enums are only ever appended to the existing ones. Providing snapshot tests for every variant will help ensure this (as well as helping ensure existing variants don't change).

We should also provide a snapshot test for each variant of the top-level StoredValue enum too, for the same reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality sequencer pertaining to the astria-sequencer crate testing
Projects
None yet
Development

No branches or pull requests

2 participants