DynMap hook buggy

[aikar]

If you login vanished, or maybe just vanishing all together, Dynmap will essentially be broken from ever reshowing on the map until restart

The DynMap author says that SV's hook code is not correct:

https://github.com/asofold/SimplyVanish/blob/master/SimplyVanish/src/me/asofold/bpl/simplyvanish/api/hooks/impl/DynmapHook.java#L53

@mikeprimm assertPlayerInvisibility is right, but setPlayerVisibility is wrong
@mikeprimm first one is for the temporary thing, and should be 'true' for invisible and 'false' for default (whether visible or not)
@mikeprimm while the second call is adjusting the show/hide configuration - and setting it to 'false' means hide
@mikeprimm In any case, the assert is the right thing - just kill the other line, and it should be fine
@mikeprimm Right - assert is a plugin-keyed 'vote' on the visiblity or invisibility - if anyone is voting for it to be invisibible, it is: else, if anyone votes for it to be visible, it is; else the show/hide setting applies (which is what setPlayerVisibility controls)