Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoCD incoming slack webhooks should ask for approval or reject option #74

Open
zerolaser opened this issue Jul 27, 2017 · 2 comments
Open

Comments

@zerolaser
Copy link

Is it possible for the Gocd Slack notification to ask for approve or reject button.

lets say a pipeline has two stages. soon after successful run of stage1 it should send a notification to slack channel. Do you approve or reject it ?
when approval button is clicked it should run stage2

@ashwanthkumar
Copy link
Owner

ashwanthkumar commented Jul 28, 2017

@zerolaser I really like the approach. But AFAIK to build action buttons and make it work, slack needs to be able to access an action url to post the status. We generally don't want to expose our CI / CD servers to the public internet.

@zerolaser
Copy link
Author

zerolaser commented Jul 28, 2017

@ashwanthkumar yeah. its a quite risk exposing it. what if you add an authentication mechanism to do so ?
will it be a risk of exposing GoCD server's user credentials to slack (incoming webhook)?

most of the cases slack and gocd will be on ldap authentication, get the slack userid and match it with GoCD user and also check if the user has permission to trigger the pipeline?

Also I am looking forward for a web interface on GoCD to configure slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants