Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material type is confusing #146

Open
Tracked by #177
mrmanc opened this issue Apr 8, 2020 · 3 comments
Open
Tracked by #177

Material type is confusing #146

mrmanc opened this issue Apr 8, 2020 · 3 comments

Comments

@mrmanc
Copy link

mrmanc commented Apr 8, 2020

Is there a reason that the material type is Github rather than GitHub Pull Requests? I think people have missed it as an option because the difference between Git and Github is so subtle.

@ashwanthkumar
Copy link
Owner

No specific reason. It's been that way since the day 1 as far as I can recall. Most of us are now used seeing Github material type. I'll keep this issue open for a while, if more users thing it should be renamed.

@kuba-lilz
Copy link

kuba-lilz commented May 29, 2020

While I got used to it by now, I indeed found it very confusing when first using the plugin.

@stephen-murby
Copy link

I agree I think this would be a much less confusing material name, I will include a rename in my (work in progress) pull request to filter out draft pull requests from triggering a pipeline run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants