Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git.fb - submodules problem #112

Open
savage7 opened this issue Oct 23, 2017 · 4 comments
Open

git.fb - submodules problem #112

savage7 opened this issue Oct 23, 2017 · 4 comments

Comments

@savage7
Copy link

savage7 commented Oct 23, 2017

I have strange problem concerning submodules. It seams that the they are not cloned correclty.
We use git.fb to build our feature, master and develop branches for git-flow.

My Repo looks like this:
Main Repo: branch/release/release_1.0 (revision abc)
-- Submodule A: Points the certain commit as head on the master

The strange thing is that the repo is cloned differently when i change the setting for default branch:

default branch: master
The submodule is checked out correctly. The submodule points to the correct head.

default branch: develop
The submodule head points to origin/master not head --> the build fails

For another repo it is the other way round: It build with default branch develop but fails for master.

It seams the the git reset it not done correctly for all submodules. Are they reset? I dont get any log output it the gocd console for this plugin.
Does this plugin some kind of merging?

@savage7
Copy link
Author

savage7 commented Oct 23, 2017

For testing purpose I added a extra task which resets all submodules accordingly:
git submodule foreach --recursive git reset --hard
git submodule update --recursive --init

This solves the issue, can you add this?

@ravenpride
Copy link

We're encountering the same issue. Is there any progress fixing it?

@ashwanthkumar
Copy link
Owner

@ravenpride Would you please be kind enough to send a PR for this issue? I would be happy to review and merge it.

@ravenpride
Copy link

@ashwanthkumar Thank you for your response. Meanwhile we found a way to work without the plugin. We just wanted to build a set of release branches with a specific pattern using one pipeline, but that caused other issues, so we discarded this way entirely and built up separate pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants