Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat Tasks - Not functioning as expected #19

Closed
ashblue opened this issue May 27, 2020 · 2 comments
Closed

Repeat Tasks - Not functioning as expected #19

ashblue opened this issue May 27, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ashblue
Copy link
Owner

ashblue commented May 27, 2020

Repeat tasks are not working as expected. This issue only affects repeaters. Current bugs are as follows.

  • Does not run Start() and Exit() when a task ends, causing tasks like Wait to automatically fail on 2nd run
  • Composites do not work with any repeat tasks

This should by fixable by doing the following. Adequate test coverage and testing will be needed to verify this doesn't create any weird bugs in the app.

  • Prove the issue with a test that shows a sequence/composite does not repeat on completion
  • Write a test to verify nested composites on repeat run as expected repeat
  • Prove the issue with a test that shows Start() and Exit() fails to run task repeat
  • Write a test to verify nested tasks inside a composite run as expected on repeat
  • TaskParentBase should run a self Reset() when success or failure returns
  • TaskBase then needs to run a Reset() on Exit

Testing when the fix is ready:

  • Tree visualizer still works as expected
  • Tree visualizer doesn't blow out with nested repeats
  • Add a nested repeat sample to the sample project that verifies the new repeater logic works as expected
@ashblue ashblue added the bug Something isn't working label May 27, 2020
@ashblue ashblue self-assigned this May 29, 2020
Repository owner deleted a comment from allcontributors bot Jun 1, 2020
@ashblue
Copy link
Owner Author

ashblue commented Jun 1, 2020

@all-contributors please add @call-stack for bug

@allcontributors
Copy link
Contributor

@ashblue

I've put up a pull request to add @call-stack! 🎉

@ashblue ashblue closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant