Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading axios to 0.28 causes httpRequest to not filter out properties with null/undefined values #173

Open
pavinduLakshan opened this issue Jul 18, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pavinduLakshan
Copy link
Contributor

Describe the issue:

$subject.

This breaks existing usage of httpRequest and httpRequestAll which might have been used with the assumption that axios will filter out the properties with falsy values.

In order to update axios, we need to update the httpRequest and httpRequestAll functions with an option to enable/disable stripping out properties with falsy values.

How to reproduce:

Update axios version to 0.28.0 in spa-sdk

Expected behavior:

Should be able to upgrade axios sdk without SDK functionality being broken.

@pavinduLakshan pavinduLakshan added the bug Something isn't working label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants