Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect the missing lock file changes in PR builder #237

Open
pavinduLakshan opened this issue Jul 29, 2024 · 0 comments
Open

Detect the missing lock file changes in PR builder #237

pavinduLakshan opened this issue Jul 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pavinduLakshan
Copy link
Contributor

Describe the issue:

When a dependency version is updated and the lock file is not updated, the release action fails due to the out-of-sync lock file.

Ideally we should be able to detect this in the PR builder itself, before merging the PR.

https://github.com/asgardeo/asgardeo-auth-react-sdk/actions/runs/10141638470

How to reproduce:

Merge a version update PR without updating the lock file accordingly.

Expected behavior:

PR builder should be able to detect this before the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant